Converting python plugin-in shellout.py from gimp 2.x to 3.x

[duke2362]

Hi iiey

Quote:Hi duke2362,

You are right about the behavior, gimp should wait there until nik program finishes before importing the image back.
But I'm not sure whether the "--wait-app" option really exists for "open" command of mac osx, it should be "-W" actually. Maybe it differ from version to version, which macOS do you use?
https://ss64.com/mac/open.html
https://www.unix.com/man_page/osx/1/open/

"--wait-app" and "-W" are the same (MacOs Sequoia 15.5) : 

Code:

-W, --wait-apps       Blocks until the used applications are closed (even if they were already running).

Quote:My other question is, could you check where the HDR Efex Pro 2 saves your images after processing? If the location is not ~/Documents/ as nikplugin.py assumes then it may not work for you with this plugin.

I didn't test all the “Nik” plugins: only Analog, Color and Silver work (in fact, I usually only use those). HDR launches but doesn't return the image. Sharpener, Viveza and Dfine crash. I'll investigate.

[iiey]

(05-28-2025, 11:28 PM)alderon Wrote:          Long story short:  your (it is yours or I'm mistaken?) plugin works fine. I just had some "portable" version of Nik Collection. I downloaded some "free" version, because I wanted to see, if there's even anything worth upgrade from Google to latest NIK.

   So, for Nik Collection v 8.0.12 I had to specify path to "bin" folder (where all .exe are) in the plugin (the "str" section). Plugin showed all exe files, which I didn't like much. Not big deal, but to make it more neat I changed filter from suffix .exe to prefix "Nik 8", because all programs starts from that. I have no idea about Python, so all changes are made with help of ChatGPT.

   Now the problem with TIF was not export, but import back to GIMP. I figured this out by manually importing TIF file. Nik Collection was saving 2 pages in TIF. If I'm not mistaken with numbers: page 0 was full size file, page 1 was thumbnail and GIMP was loading page 1 as new layer. After bunch of trials and errors sent to ChatGPT, that AI crap finally made working changes. I don't want to make a mess, but I can send you the code. New code suppose to load whole TIF, check for biggest part/page of it and paste that part into new layer. It works now anyway.


   I wanted TIF files, because when I edit my photos, I always work with uncompressed files and final TIF I export to jpg. So if I had jpg on the way, it's kind of bad for me.


   Regards.

Hi alderon,

thank you for the detailed explanation  Sorry that it didn't work out of the box for you and you had to do a lot of stuff.
During your trials with the plugin, there was also an issue in github about DxO Nik Collection so I also made changes to work better with this version. The latest one is v3.2.2-rc (will not showed .exe again without File/Folder Rename):
https://github.com/iiey/nikgimp/issues/1...2902750494

You are right about uncompressed data. It would be nice if you could send me your code, maybe I can figure out an approach to adapt it in the main plugin without making TIF and JPG handling more complex.

Thank you in advance!

[alderon]

(06-02-2025, 04:47 PM)iiey Wrote:

(05-28-2025, 11:28 PM)alderon Wrote:          Long story short:  your (it is yours or I'm mistaken?) plugin works fine. I just had some "portable" version of Nik Collection. I downloaded some "free" version, because I wanted to see, if there's even anything worth upgrade from Google to latest NIK.

   So, for Nik Collection v 8.0.12 I had to specify path to "bin" folder (where all .exe are) in the plugin (the "str" section). Plugin showed all exe files, which I didn't like much. Not big deal, but to make it more neat I changed filter from suffix .exe to prefix "Nik 8", because all programs starts from that. I have no idea about Python, so all changes are made with help of ChatGPT.

   Now the problem with TIF was not export, but import back to GIMP. I figured this out by manually importing TIF file. Nik Collection was saving 2 pages in TIF. If I'm not mistaken with numbers: page 0 was full size file, page 1 was thumbnail and GIMP was loading page 1 as new layer. After bunch of trials and errors sent to ChatGPT, that AI crap finally made working changes. I don't want to make a mess, but I can send you the code. New code suppose to load whole TIF, check for biggest part/page of it and paste that part into new layer. It works now anyway.


   I wanted TIF files, because when I edit my photos, I always work with uncompressed files and final TIF I export to jpg. So if I had jpg on the way, it's kind of bad for me.


   Regards.

Hi alderon,

thank you for the detailed explanation  Sorry that it didn't work out of the box for you and you had to do a lot of stuff.
During your trials with the plugin, there was also an issue in github about DxO Nik Collection so I also made changes to work better with this version. The latest one is v3.2.2-rc (will not showed .exe again without File/Folder Rename):
https://github.com/iiey/nikgimp/issues/1...2902750494

You are right about uncompressed data. It would be nice if you could send me your code, maybe I can figure out an approach to adapt it in the main plugin without making TIF and JPG handling more complex.

Thank you in advance!

Don't sorry lol If not you, I wouldn't have any working plugin, no chance I would port it from Gimp 2.0.

This is what I changed for TIF:

change jpg to TIF here:

Code:

temp_path = os.path.join(tempfile.gettempdir(), f"tmpNik_{i}.tif")

New code to import TIF:

Code:

def process_result(
    target_layer: Gimp.Layer,
    tmp_img: Gimp.Image,
    tmp_filepath: str,
) -> None:
    """Load page with highest resolution from TIF"""

    loaded_image: Gimp.Image = Gimp.file_load(
        Gimp.RunMode.NONINTERACTIVE,
        Gio.File.new_for_path(tmp_filepath),
    )

    layers = loaded_image.get_layers()
    if not layers:
        raise RuntimeError("No layers found in loaded image.")

    # ? Find layer with highest resolution (skip miniatures)
    max_layer = max(layers, key=lambda l: l.get_width() * l.get_height())

    buffer = Gimp.edit_named_copy([max_layer], "ShellOutTemp")
    target_layer.resize(max_layer.get_width(), max_layer.get_height(), 0, 0)
    sel = Gimp.edit_named_paste(target_layer, buffer, True)

    Gimp.Item.transform_translate(
        target_layer,
        (tmp_img.get_width() - max_layer.get_width()) / 2,
        (tmp_img.get_height() - max_layer.get_height()) / 2,
    )

    target_layer.edit_clear()
    Gimp.buffer_delete(buffer)
    Gimp.floating_sel_anchor(sel)

    loaded_image.delete()


def cleanup(tmp_filepath: Optional[str], tmp_images: List[Gimp.Image]) -> None:
    """Clean up temporary resources"""

    if tmp_filepath and os.path.exists(tmp_filepath):
        os.remove(tmp_filepath)

    for tmp_img in tmp_images:
        tmp_img.delete()

Whole plugin in attachment. (If I added it correctly...) Just change extension from txt to py.

Regards.
Norbert